diff options
author | Borislav Petkov <[email protected]> | 2015-08-08 10:46:02 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2015-09-17 06:06:54 -0700 |
commit | 2110d70c5e58326a10e93cfefdc0b3686e2ada12 (patch) | |
tree | b0a272279c817b91ba3bf8e632dfcc930e9d6d2c /tools/perf/scripts/python/export-to-postgresql.py | |
parent | 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f (diff) |
cpu/cacheinfo: Fix teardown path
Philip Müller reported a hang when booting 32-bit 4.1 kernel on an AMD
box. A fragment of the splat was enough to pinpoint the issue:
task: f58e0000 ti: f58e8000 task.ti: f58e800
EIP: 0060:[<c135a903>] EFLAGS: 00010206 CPU: 0
EIP is at free_cache_attributes+0x83/0xd0
EAX: 00000001 EBX: f589d46c ECX: 00000090 EDX: 360c2000
ESI: 00000000 EDI: c1724a80 EBP: f58e9ec0 ESP: f58e9ea0
DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
CR0: 8005003b CR2: 000000ac CR3: 01731000 CR4: 000006d0
cache_shared_cpu_map_setup() did check sibling CPUs cacheinfo descriptor
while the respective teardown path cache_shared_cpu_map_remove() didn't.
Fix that.
>From tglx's version: to be on the safe side, move the cacheinfo
descriptor check to free_cache_attributes(), thus cleaning up the
hotplug path a little and making this even more robust.
Reported-and-tested-by: Philip Müller <[email protected]>
Reviewed-by: Thomas Gleixner <[email protected]>
Acked-by: Sudeep Holla <[email protected]>
Cc: <[email protected]> # 4.1
Cc: Andre Przywara <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Philip Müller <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Borislav Petkov <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions