diff options
| author | Andrea Arcangeli <[email protected]> | 2019-06-28 12:07:14 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2019-06-29 16:43:45 +0800 |
| commit | 1bf4580e00a248a2c86269125390eb3648e1877c (patch) | |
| tree | 63f8510d48380fcf5d8133c2270b45501106769d /tools/perf/scripts/python/export-to-postgresql.py | |
| parent | 8708e13c6a0600625eea3aebd027c0715a5d2bb2 (diff) | |
fork,memcg: alloc_thread_stack_node needs to set tsk->stack
Commit 5eed6f1dff87 ("fork,memcg: fix crash in free_thread_stack on
memcg charge fail") corrected two instances, but there was a third
instance of this bug.
Without setting tsk->stack, if memcg_charge_kernel_stack fails, it'll
execute free_thread_stack() on a dangling pointer.
Enterprise kernels are compiled with VMAP_STACK=y so this isn't
critical, but custom VMAP_STACK=n builds should have some performance
advantage, with the drawback of risking to fail fork because compaction
didn't succeed. So as long as VMAP_STACK=n is a supported option it's
worth fixing it upstream.
Link: http://lkml.kernel.org/r/[email protected]
Fixes: 9b6f7e163cd0 ("mm: rework memcg kernel stack accounting")
Signed-off-by: Andrea Arcangeli <[email protected]>
Reviewed-by: Rik van Riel <[email protected]>
Acked-by: Roman Gushchin <[email protected]>
Acked-by: Michal Hocko <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions