aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/call-graph-from-sql.py
diff options
context:
space:
mode:
authorNamhyung Kim <[email protected]>2017-10-20 14:15:33 +0900
committerArnaldo Carvalho de Melo <[email protected]>2017-10-31 16:14:50 -0300
commitd6332a176b869df1839abb26c8f80026a66d21d6 (patch)
tree9e01c349472558def29b2cc337f29e1410cb86a1 /tools/perf/scripts/python/call-graph-from-sql.py
parent021b462a51de48dd84f12f5046b5b57a362d6506 (diff)
perf callchain: Fix double mapping al->addr for children without self period
Milian Wolff found a problem he described in [1] and that for him would get fixed: "Note how most of the large offset values are now gone. Most notably, we get proper srcline resolution for the random.h and complex headers." Then Namhyung found the root cause: "I looked into it and found a bug handling cumulative (children) entries. For children entries that have no self period, the al->addr (so he->ip) ends up having an doubly-mapped address. It seems to be there from the beginning but only affects entries that have no srclines - finding srcline itself is done using a different address but it will show the invalid address if no srcline was found. I think we should fix the commit c7405d85d7a3 ("perf tools: Update cpumode for each cumulative entry")." [1] https://lkml.kernel.org/r/[email protected] Reported-by: Milian Wolff <[email protected]> Signed-off-by: Namhyung Kim <[email protected]> Tested-by: Milian Wolff <[email protected]> Cc: Jin Yao <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: [email protected] Fixes: c7405d85d7a3 ("perf tools: Update cpumode for each cumulative entry") Link: https://lkml.kernel.org/r/20171020051533.GA2746@sejong Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-sql.py')
0 files changed, 0 insertions, 0 deletions