diff options
author | Chris Wilson <[email protected]> | 2018-05-29 14:29:18 +0100 |
---|---|---|
committer | Jani Nikula <[email protected]> | 2018-05-31 14:27:03 +0300 |
commit | bc61ec46e83f84b7f42bd775e18567471f1aaaa6 (patch) | |
tree | 5ed8167c0c8a349f6ae696729fd6e4e60337057a /tools/perf/scripts/python/call-graph-from-sql.py | |
parent | 368b554d63948133aca05e63ff8f5f4fbc2804d4 (diff) |
drm/i915: Remove stale asserts from i915_gem_find_active_request()
Since we use i915_gem_find_active_request() from inside
intel_engine_dump() and may call that at any time, we do not guarantee
that the engine is paused nor that the signal kthreads and irq handler
are suspended, so we cannot assert that the breadcrumb doesn't advance
and that the irq hasn't happened on another CPU signaling the request we
believe to be idle.
The second assert removed (that request->engine == engine) remains
valid, but is now more rigorously checked during retirement.
Fixes: f636edb214a5 ("drm/i915: Make i915_engine_info pretty printer to standalone")
Signed-off-by: Chris Wilson <[email protected]>
Cc: Mika Kuoppala <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Reviewed-by: Tvrtko Ursulin <[email protected]>
(cherry picked from commit cc7cc5343584d90e74b7c929ff2c9a2ec8b49cfe)
Signed-off-by: Jani Nikula <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-sql.py')
0 files changed, 0 insertions, 0 deletions