diff options
author | Andrey Ryabinin <[email protected]> | 2015-12-14 15:47:23 +0300 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2016-01-06 11:01:05 +0100 |
commit | 9e0e83a1eca66f8369e5a02973f85aad65c32416 (patch) | |
tree | 75d4c8d90c3dcde20942e77a6542fe1d4620d258 /tools/perf/scripts/python/call-graph-from-postgresql.py | |
parent | ee9a7d2cb0cf1a1498478bc923d911f3d9c910ac (diff) |
sched/fair: Fix multiplication overflow on 32-bit systems
Make 'r' 64-bit type to avoid overflow in 'r * LOAD_AVG_MAX'
on 32-bit systems:
UBSAN: Undefined behaviour in kernel/sched/fair.c:2785:18
signed integer overflow:
87950 * 47742 cannot be represented in type 'int'
The most likely effect of this bug are bad load average numbers
resulting in weird scheduling. It's also likely that this can
persist for a longer time - until the system goes idle for
a long time so that all load avg numbers get reset.
[ This is the CFS load average metric, not the procfs output, which
is separate. ]
Signed-off-by: Andrey Ryabinin <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Fixes: 9d89c257dfb9 ("sched/fair: Rewrite runnable load and utilization average tracking")
Link: http://lkml.kernel.org/r/[email protected]
[ Improved the changelog. ]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-postgresql.py')
0 files changed, 0 insertions, 0 deletions