diff options
author | Tony Battersby <[email protected]> | 2015-02-13 12:09:44 -0500 |
---|---|---|
committer | James Bottomley <[email protected]> | 2015-02-17 06:55:32 -0800 |
commit | 7568615c1054907ea8c7701ab86dad51aa099888 (patch) | |
tree | 9a8fbf348961fd4970423b51a41ce7ae7b3e0421 /tools/perf/scripts/python/call-graph-from-postgresql.py | |
parent | 3b524a683af8991b4eab4182b947c65f0ce1421b (diff) |
sg: fix unkillable I/O wait deadlock with scsi-mq
When using the write()/read() interface for submitting commands, the
SCSI generic driver does not call blk_put_request() on a completed SCSI
command until userspace calls read() to get the command completion.
Since scsi-mq uses a fixed number of preallocated requests, this makes
it possible for userspace to exhaust the entire preallocated supply of
requests. For places in the kernel that call blk_get_request() with
GFP_KERNEL, this can cause the calling process to deadlock in a
permanent unkillable I/O wait in blk_get_request() -> ... -> bt_get().
For places in the kernel that call blk_get_request() with GFP_ATOMIC,
this can cause blk_get_request() always to return -EWOULDBLOCK. Note
that these problems happen only if scsi-mq is enabled. Prevent the
problems by calling blk_put_request() as soon as the SCSI command
completes instead of waiting for userspace to call read().
Cc: <[email protected]> # 3.17+
Signed-off-by: Tony Battersby <[email protected]>
Acked-by: Douglas Gilbert <[email protected]>
Tested-by: Douglas Gilbert <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-postgresql.py')
0 files changed, 0 insertions, 0 deletions