diff options
| author | Will Deacon <[email protected]> | 2020-05-19 12:56:05 +0100 |
|---|---|---|
| committer | Will Deacon <[email protected]> | 2020-05-21 12:59:26 +0100 |
| commit | a4eb355a3fdad85d16e4b098e8d56bb28b812ce0 (patch) | |
| tree | 6926231c6775a41e08ff85376027ef2d7e65cfdd /mm/page_alloc.c | |
| parent | 9a964285572b5a3ea268bd744bb6837aecf09640 (diff) | |
arm64: vdso: Fix CFI directives in sigreturn trampoline
Daniel reports that the .cfi_startproc is misplaced for the sigreturn
trampoline, which causes LLVM's unwinder to misbehave:
| I run into this with LLVM’s unwinder.
| This combination was always broken.
This prompted Dave to question our use of CFI directives more generally,
and I ended up going down a rabbit hole trying to figure out how this
very poorly documented stuff gets used.
Move the CFI directives so that the "mysterious NOP" is included in
the .cfi_{start,end}proc block and add a bunch of comments so that I
can save myself another headache in future.
Cc: Tamas Zsoldos <[email protected]>
Reported-by: Dave Martin <[email protected]>
Reported-by: Daniel Kiss <[email protected]>
Tested-by: Daniel Kiss <[email protected]>
Signed-off-by: Will Deacon <[email protected]>
Diffstat (limited to 'mm/page_alloc.c')
0 files changed, 0 insertions, 0 deletions