diff options
author | Zefan Li <[email protected]> | 2014-09-25 09:41:02 +0800 |
---|---|---|
committer | Tejun Heo <[email protected]> | 2014-09-24 22:16:06 -0400 |
commit | 2ad654bc5e2b211e92f66da1d819e47d79a866f0 (patch) | |
tree | c638346ac104f054fc61649a8739b004d06aff59 /lib/string.c | |
parent | e0e5070b20e01f0321f97db4e4e174f3f6b49e50 (diff) |
cpuset: PF_SPREAD_PAGE and PF_SPREAD_SLAB should be atomic flags
When we change cpuset.memory_spread_{page,slab}, cpuset will flip
PF_SPREAD_{PAGE,SLAB} bit of tsk->flags for each task in that cpuset.
This should be done using atomic bitops, but currently we don't,
which is broken.
Tetsuo reported a hard-to-reproduce kernel crash on RHEL6, which happened
when one thread tried to clear PF_USED_MATH while at the same time another
thread tried to flip PF_SPREAD_PAGE/PF_SPREAD_SLAB. They both operate on
the same task.
Here's the full report:
https://lkml.org/lkml/2014/9/19/230
To fix this, we make PF_SPREAD_PAGE and PF_SPREAD_SLAB atomic flags.
v4:
- updated mm/slab.c. (Fengguang Wu)
- updated Documentation.
Cc: Peter Zijlstra <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Miao Xie <[email protected]>
Cc: Kees Cook <[email protected]>
Fixes: 950592f7b991 ("cpusets: update tasks' page/slab spread flags in time")
Cc: <[email protected]> # 2.6.31+
Reported-by: Tetsuo Handa <[email protected]>
Signed-off-by: Zefan Li <[email protected]>
Signed-off-by: Tejun Heo <[email protected]>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions