diff options
| author | Dave Hansen <[email protected]> | 2012-05-29 15:06:46 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2012-05-29 16:22:24 -0700 |
| commit | c50ac050811d6485616a193eb0f37bfbd191cc89 (patch) | |
| tree | e237c67e83182bad5744e17c867bb6bceb207544 /lib/mpi/generic_mpih-add1.c | |
| parent | 5c2b8a162b5f8616f709bf20d5ec88f709485522 (diff) | |
hugetlb: fix resv_map leak in error path
When called for anonymous (non-shared) mappings, hugetlb_reserve_pages()
does a resv_map_alloc(). It depends on code in hugetlbfs's
vm_ops->close() to release that allocation.
However, in the mmap() failure path, we do a plain unmap_region() without
the remove_vma() which actually calls vm_ops->close().
This is a decent fix. This leak could get reintroduced if new code (say,
after hugetlb_reserve_pages() in hugetlbfs_file_mmap()) decides to return
an error. But, I think it would have to unroll the reservation anyway.
Christoph's test case:
http://marc.info/?l=linux-mm&m=133728900729735
This patch applies to 3.4 and later. A version for earlier kernels is at
https://lkml.org/lkml/2012/5/22/418.
Signed-off-by: Dave Hansen <[email protected]>
Acked-by: Mel Gorman <[email protected]>
Acked-by: KOSAKI Motohiro <[email protected]>
Reported-by: Christoph Lameter <[email protected]>
Tested-by: Christoph Lameter <[email protected]>
Cc: Andrea Arcangeli <[email protected]>
Cc: <[email protected]> [2.6.32+]
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/mpi/generic_mpih-add1.c')
0 files changed, 0 insertions, 0 deletions