diff options
author | Ming Lei <[email protected]> | 2021-06-28 10:33:12 +0800 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2021-06-29 07:41:08 -0600 |
commit | 2705dfb2094777e405e065105e307074af8965c1 (patch) | |
tree | 1fdc528a77f5be9455dcedf07b303dbceac04bd1 /include/linux/compiler_attributes.h | |
parent | c06bc5a3fb42304d815a2dc41e324b5a97c9f7da (diff) |
block: fix discard request merge
ll_new_hw_segment() is reached only in case of single range discard
merge, and we don't have max discard segment size limit actually, so
it is wrong to run the following check:
if (req->nr_phys_segments + nr_phys_segs > blk_rq_get_max_segments(req))
it may be always false since req->nr_phys_segments is initialized as
one, and bio's segment count is still 1, blk_rq_get_max_segments(reg)
is 1 too.
Fix the issue by not doing the check and bypassing the calculation of
discard request's nr_phys_segments.
Based on analysis from Wang Shanker.
Cc: Christoph Hellwig <[email protected]>
Reported-by: Wang Shanker <[email protected]>
Signed-off-by: Ming Lei <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'include/linux/compiler_attributes.h')
0 files changed, 0 insertions, 0 deletions