diff options
author | Peter Münster <[email protected]> | 2024-04-24 15:51:52 +0200 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2024-04-25 08:34:18 -0700 |
commit | e3eb7dd47bd4806f00e104eb6da092c435f9fb21 (patch) | |
tree | 1bbde00ac43201d537c49f87b4e0469aff1b6970 /drivers/net/ethernet/intel/igc | |
parent | 0844370f8945086eb9335739d10205dcea8d707b (diff) |
net: b44: set pause params only when interface is up
b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
unconditionally, but b44::rx_buffers is only valid when the
device is up (they get allocated in b44_open(), and deallocated
again in b44_close()), any other time these are just a NULL pointers.
So if you try to change the pause params while the network interface
is disabled/administratively down, everything explodes (which likely
netifd tries to do).
Link: https://github.com/openwrt/openwrt/issues/13789
Fixes: 1da177e4c3f4 (Linux-2.6.12-rc2)
Cc: [email protected]
Reported-by: Peter Münster <[email protected]>
Suggested-by: Jonas Gorski <[email protected]>
Signed-off-by: Vaclav Svoboda <[email protected]>
Tested-by: Peter Münster <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Peter Münster <[email protected]>
Reviewed-by: Michael Chan <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc')
0 files changed, 0 insertions, 0 deletions