diff options
author | Przemek Kitszel <[email protected]> | 2024-03-05 17:02:02 +0100 |
---|---|---|
committer | Tony Nguyen <[email protected]> | 2024-03-25 09:57:21 -0700 |
commit | aec806fb4afba5fe80b09e29351379a4292baa43 (patch) | |
tree | d636f3ef2090cf80176ee56512596a5fc1d2efca /drivers/net/ethernet/intel/igc | |
parent | 1cb7fdb1dfde1aab66780b4ba44dba6402172111 (diff) |
ixgbe: avoid sleeping allocation in ixgbe_ipsec_vf_add_sa()
Change kzalloc() flags used in ixgbe_ipsec_vf_add_sa() to GFP_ATOMIC, to
avoid sleeping in IRQ context.
Dan Carpenter, with the help of Smatch, has found following issue:
The patch eda0333ac293: "ixgbe: add VF IPsec management" from Aug 13,
2018 (linux-next), leads to the following Smatch static checker
warning: drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c:917 ixgbe_ipsec_vf_add_sa()
warn: sleeping in IRQ context
The call tree that Smatch is worried about is:
ixgbe_msix_other() <- IRQ handler
-> ixgbe_msg_task()
-> ixgbe_rcv_msg_from_vf()
-> ixgbe_ipsec_vf_add_sa()
Fixes: eda0333ac293 ("ixgbe: add VF IPsec management")
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/intel-wired-lan/[email protected]
Reviewed-by: Michal Kubiak <[email protected]>
Signed-off-by: Przemek Kitszel <[email protected]>
Reviewed-by: Shannon Nelson <[email protected]>
Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <[email protected]>
Diffstat (limited to 'drivers/net/ethernet/intel/igc')
0 files changed, 0 insertions, 0 deletions