diff options
| author | Neil Horman <[email protected]> | 2013-09-27 12:53:35 -0400 |
|---|---|---|
| committer | Joerg Roedel <[email protected]> | 2013-10-04 16:19:26 +0200 |
| commit | 05104a4e8713b27291c7bb49c1e7e68b4e243571 (patch) | |
| tree | dbd54a2c9e1e5aa55f9fc058c383a4c5a3180fa6 /drivers/iommu/intel_irq_remapping.c | |
| parent | 15c03dd4859ab16f9212238f29dd315654aa94f6 (diff) | |
iommu: Remove stack trace from broken irq remapping warning
The warning for the irq remapping broken check in intel_irq_remapping.c is
pretty pointless. We need the warning, but we know where its comming from, the
stack trace will always be the same, and it needlessly triggers things like
Abrt. This changes the warning to just print a text warning about BIOS being
broken, without the stack trace, then sets the appropriate taint bit. Since we
automatically disable irq remapping, theres no need to contiue making Abrt jump
at this problem
Signed-off-by: Neil Horman <[email protected]>
CC: Joerg Roedel <[email protected]>
CC: Bjorn Helgaas <[email protected]>
CC: Andy Lutomirski <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Joerg Roedel <[email protected]>
Diffstat (limited to 'drivers/iommu/intel_irq_remapping.c')
| -rw-r--r-- | drivers/iommu/intel_irq_remapping.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c index f71673dbb23d..b97d70b1abe0 100644 --- a/drivers/iommu/intel_irq_remapping.c +++ b/drivers/iommu/intel_irq_remapping.c @@ -525,12 +525,13 @@ static int __init intel_irq_remapping_supported(void) if (disable_irq_remap) return 0; if (irq_remap_broken) { - WARN_TAINT(1, TAINT_FIRMWARE_WORKAROUND, - "This system BIOS has enabled interrupt remapping\n" - "on a chipset that contains an erratum making that\n" - "feature unstable. To maintain system stability\n" - "interrupt remapping is being disabled. Please\n" - "contact your BIOS vendor for an update\n"); + printk(KERN_WARNING + "This system BIOS has enabled interrupt remapping\n" + "on a chipset that contains an erratum making that\n" + "feature unstable. To maintain system stability\n" + "interrupt remapping is being disabled. Please\n" + "contact your BIOS vendor for an update\n"); + add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK); disable_irq_remap = 1; return 0; } |