diff options
| author | Lucas De Marchi <lucas.demarchi@intel.com> | 2023-04-01 01:51:47 -0700 |
|---|---|---|
| committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2023-12-19 18:31:31 -0500 |
| commit | 60d5c6abc289cc5d561758e71fb2c392c1ec2161 (patch) | |
| tree | 0b2841b7c82e5c7eca655211ccd40c69b6b57dc3 /drivers/gpu/drm/xe/tests/xe_dma_buf.c | |
| parent | af049be5a33e12fb993028eb378fd61545e72f5e (diff) | |
drm/xe: Use symbol namespace for kunit tests
Instead of simply using EXPORT_SYMBOL() to export the functions needed
in xe.ko to be be called across modules, use EXPORT_SYMBOL_IF_KUNIT()
which will export the symbol under the EXPORTED_FOR_KUNIT_TESTING
namespace.
This avoids accidentally "leaking" these functions and letting them be
called from outside the kunit tests. If these functiosn are accidentally
called from another module, they receive a modpost error like below:
ERROR: modpost: module XXXXXXX uses symbol
xe_ccs_migrate_kunit from namespace EXPORTED_FOR_KUNIT_TESTING,
but does not import it.
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Link: https://lore.kernel.org/r/20230401085151.1786204-4-lucas.demarchi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Diffstat (limited to 'drivers/gpu/drm/xe/tests/xe_dma_buf.c')
| -rw-r--r-- | drivers/gpu/drm/xe/tests/xe_dma_buf.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/xe/tests/xe_dma_buf.c b/drivers/gpu/drm/xe/tests/xe_dma_buf.c index cf9dddf1a8d7..513a3b3362e9 100644 --- a/drivers/gpu/drm/xe/tests/xe_dma_buf.c +++ b/drivers/gpu/drm/xe/tests/xe_dma_buf.c @@ -4,6 +4,7 @@ */ #include <kunit/test.h> +#include <kunit/visibility.h> #include "tests/xe_dma_buf_test.h" #include "tests/xe_pci_test.h" @@ -259,4 +260,4 @@ void xe_dma_buf_kunit(struct kunit *test) { xe_call_for_each_device(dma_buf_run_device); } -EXPORT_SYMBOL(xe_dma_buf_kunit); +EXPORT_SYMBOL_IF_KUNIT(xe_dma_buf_kunit); |