diff options
author | Nirmoy Das <[email protected]> | 2024-04-22 22:19:51 +0200 |
---|---|---|
committer | Andi Shyti <[email protected]> | 2024-04-24 18:48:32 +0200 |
commit | 4d3421e04c5dc38baf15224c051256204f223c15 (patch) | |
tree | 55e9cca99f1d7a86e9dba479d47f74059761bf9b /drivers/gpu/drm/amd/amdgpu/atom.c | |
parent | 31c3c53ee3a3e39aac690dffab75765d25e318dd (diff) |
drm/i915: Fix gt reset with GuC submission is disabled
Currently intel_gt_reset() kills the GuC and then resets requested
engines. This is problematic because there is a dedicated CSB FIFO
which only GuC can access and if that FIFO fills up, the hardware
will block on the next context switch until there is space that means
the system is effectively hung. If an engine is reset whilst actively
executing a context, a CSB entry will be sent to say that the context
has gone idle. Thus if reset happens on a very busy system then
killing GuC before killing the engines will lead to deadlock because
of filled up CSB FIFO.
To address this issue, the GuC should be killed only after resetting
the requested engines and before calling intel_gt_init_hw().
v2: Improve commit message(John)
Cc: John Harrison <[email protected]>
Signed-off-by: Nirmoy Das <[email protected]>
Reviewed-by: John Harrison <[email protected]>
Reviewed-by: Andi Shyti <[email protected]>
Signed-off-by: Andi Shyti <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'drivers/gpu/drm/amd/amdgpu/atom.c')
0 files changed, 0 insertions, 0 deletions