diff options
author | Giulio Benetti <[email protected]> | 2022-11-04 21:46:18 +0100 |
---|---|---|
committer | Russell King (Oracle) <[email protected]> | 2022-11-07 14:16:44 +0000 |
commit | 340a982825f76f1cff0daa605970fe47321b5ee7 (patch) | |
tree | cdf55efdf516d84ac2fdee2bb6b1b9a7b2834916 /arch/arm/mm/fault.c | |
parent | 612695bccfdbd52004551308a55bae410e7cd22f (diff) |
ARM: 9266/1: mm: fix no-MMU ZERO_PAGE() implementation
Actually in no-MMU SoCs(i.e. i.MXRT) ZERO_PAGE(vaddr) expands to
```
virt_to_page(0)
```
that in order expands to:
```
pfn_to_page(virt_to_pfn(0))
```
and then virt_to_pfn(0) to:
```
((((unsigned long)(0) - PAGE_OFFSET) >> PAGE_SHIFT) +
PHYS_PFN_OFFSET)
```
where PAGE_OFFSET and PHYS_PFN_OFFSET are the DRAM offset(0x80000000) and
PAGE_SHIFT is 12. This way we obtain 16MB(0x01000000) summed to the base of
DRAM(0x80000000).
When ZERO_PAGE(0) is then used, for example in bio_add_page(), the page
gets an address that is out of DRAM bounds.
So instead of using fake virtual page 0 let's allocate a dedicated
zero_page during paging_init() and assign it to a global 'struct page *
empty_zero_page' the same way mmu.c does and it's the same approach used
in m68k with commit dc068f462179 as discussed here[0]. Then let's move
ZERO_PAGE() definition to the top of pgtable.h to be in common between
mmu.c and nommu.c.
[0]: https://lore.kernel.org/linux-m68k/[email protected]/T/#m1266ceb63
ad140743174d6b3070364d3c9a5179b
Signed-off-by: Giulio Benetti <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Russell King (Oracle) <[email protected]>
Diffstat (limited to 'arch/arm/mm/fault.c')
0 files changed, 0 insertions, 0 deletions