e298d8a38b
led_blink_set[_oneshot]()'s delay_on and delay_off function parameters are pass by reference, so that hw-blink implementations can report back the actual achieved delays when the values have been rounded to something the hw supports. This is really only interesting for the sysfs API / the timer trigger. Other triggers don't really care about this and none of the callers of led_trigger_blink[_oneshot]() do anything with the returned delay values. Change the led_trigger_blink[_oneshot]() delay parameters to pass-by-value, there are 2 reasons for this: 1. led_cdev->blink_set() may sleep, while led_trigger_blink() may not. So on hw where led_cdev->blink_set() sleeps the call needs to be deferred to a workqueue, in which case the actual achieved delays are unknown (this is a preparation patch for the deferring). 2. Since the callers don't care about the actual achieved delays, allowing callers to directly pass a value leads to simpler code for most callers. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> Tested-by: Yauhen Kharuzhy <jekhor@gmail.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> Acked-by: Florian Westphal <fw@strlen.de> Link: https://lore.kernel.org/r/20230510162234.291439-2-hdegoede@redhat.com Signed-off-by: Lee Jones <lee@kernel.org>
37 lines
856 B
C
37 lines
856 B
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* LED MTD trigger
|
|
*
|
|
* Copyright 2016 Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
|
|
*
|
|
* Based on LED IDE-Disk Activity Trigger
|
|
*
|
|
* Copyright 2006 Openedhand Ltd.
|
|
*
|
|
* Author: Richard Purdie <rpurdie@openedhand.com>
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/leds.h>
|
|
|
|
#define BLINK_DELAY 30
|
|
|
|
DEFINE_LED_TRIGGER(ledtrig_mtd);
|
|
DEFINE_LED_TRIGGER(ledtrig_nand);
|
|
|
|
void ledtrig_mtd_activity(void)
|
|
{
|
|
led_trigger_blink_oneshot(ledtrig_mtd, BLINK_DELAY, BLINK_DELAY, 0);
|
|
led_trigger_blink_oneshot(ledtrig_nand, BLINK_DELAY, BLINK_DELAY, 0);
|
|
}
|
|
EXPORT_SYMBOL(ledtrig_mtd_activity);
|
|
|
|
static int __init ledtrig_mtd_init(void)
|
|
{
|
|
led_trigger_register_simple("mtd", &ledtrig_mtd);
|
|
led_trigger_register_simple("nand-disk", &ledtrig_nand);
|
|
|
|
return 0;
|
|
}
|
|
device_initcall(ledtrig_mtd_init);
|