9852f47ac7
After [1] in upstream LLVM, ld.lld's version output became slightly different when the cmake configuration option LLVM_APPEND_VC_REV is disabled. Before: Debian LLD 19.0.0 (compatible with GNU linkers) After: Debian LLD 19.0.0, compatible with GNU linkers This results in ld-version.sh failing with scripts/ld-version.sh: 18: arithmetic expression: expecting EOF: "10000 * 19 + 100 * 0 + 0," because the trailing comma is included in the patch level part of the expression. While [1] has been partially reverted in [2] to avoid this breakage (as it impacts the configuration stage and it is present in all LTS branches), it would be good to make ld-version.sh more robust against such miniscule changes like this one. Use POSIX shell parameter expansion [3] to remove the largest suffix after just numbers and periods, replacing of the current removal of everything after a hyphen. ld-version.sh continues to work for a number of distributions (Arch Linux, Debian, and Fedora) and the kernel.org toolchains and no longer errors on a version of ld.lld with [1]. Fixes:02aff85922("kbuild: check the minimum linker version in Kconfig") Link:0f9fbbb63c[1] Link:649cdfc4b6[2] Link: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html [3] Suggested-by: Fangrui Song <maskray@google.com> Reviewed-by: Fangrui Song <maskray@google.com> Signed-off-by: Nathan Chancellor <nathan@kernel.org> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
78 lines
1.8 KiB
Bash
Executable file
78 lines
1.8 KiB
Bash
Executable file
#!/bin/sh
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Print the linker name and its version in a 5 or 6-digit form.
|
|
# Also, perform the minimum version check.
|
|
|
|
set -e
|
|
|
|
# Convert the version string x.y.z to a canonical 5 or 6-digit form.
|
|
get_canonical_version()
|
|
{
|
|
IFS=.
|
|
set -- $1
|
|
|
|
# If the 2nd or 3rd field is missing, fill it with a zero.
|
|
#
|
|
# The 4th field, if present, is ignored.
|
|
# This occurs in development snapshots as in 2.35.1.20201116
|
|
echo $((10000 * $1 + 100 * ${2:-0} + ${3:-0}))
|
|
}
|
|
|
|
orig_args="$@"
|
|
|
|
# Get the first line of the --version output.
|
|
IFS='
|
|
'
|
|
set -- $(LC_ALL=C "$@" --version)
|
|
|
|
# Split the line on spaces.
|
|
IFS=' '
|
|
set -- $1
|
|
|
|
min_tool_version=$(dirname $0)/min-tool-version.sh
|
|
|
|
if [ "$1" = GNU -a "$2" = ld ]; then
|
|
shift $(($# - 1))
|
|
version=$1
|
|
min_version=$($min_tool_version binutils)
|
|
name=BFD
|
|
disp_name="GNU ld"
|
|
elif [ "$1" = GNU -a "$2" = gold ]; then
|
|
echo "gold linker is not supported as it is not capable of linking the kernel proper." >&2
|
|
exit 1
|
|
else
|
|
while [ $# -gt 1 -a "$1" != "LLD" ]; do
|
|
shift
|
|
done
|
|
|
|
if [ "$1" = LLD ]; then
|
|
version=$2
|
|
min_version=$($min_tool_version llvm)
|
|
name=LLD
|
|
disp_name=LLD
|
|
else
|
|
echo "$orig_args: unknown linker" >&2
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
# There may be something after the version, such as a distribution's package
|
|
# release number (like Fedora's "2.34-4.fc32") or punctuation (like LLD briefly
|
|
# added before the "compatible with GNU linkers" string), so remove everything
|
|
# after just numbers and periods.
|
|
version=${version%%[!0-9.]*}
|
|
|
|
cversion=$(get_canonical_version $version)
|
|
min_cversion=$(get_canonical_version $min_version)
|
|
|
|
if [ "$cversion" -lt "$min_cversion" ]; then
|
|
echo >&2 "***"
|
|
echo >&2 "*** Linker is too old."
|
|
echo >&2 "*** Your $disp_name version: $version"
|
|
echo >&2 "*** Minimum $disp_name version: $min_version"
|
|
echo >&2 "***"
|
|
exit 1
|
|
fi
|
|
|
|
echo $name $cversion
|