Blaster4385/linux-IllusionX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()

Browse source 
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

BTW, change the return value from 'ENXIO' to 'ENODEV',
perfer ENODEV which means no such device.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20211008092858.495-7-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Cai Huoqing 2021-10-08 17:28:55 +08:00 committed by Jonathan Cameron
parent a5999024b5
commit 94f08a0668
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/iio/adc/qcom-pm8xxx-xoadc.c
View file

@ -910,16 +910,15 @@ static int pm8xxx_xoadc_probe(struct platform_device *pdev)
map = dev_get_regmap(dev->parent, NULL); map = dev_get_regmap(dev->parent, NULL);
if (!map) { if (!map) {
dev_err(dev, "parent regmap unavailable.\n"); dev_err(dev, "parent regmap unavailable.\n");
return -ENXIO; return -ENODEV;
} }
adc->map = map; adc->map = map;
/* Bring up regulator */ /* Bring up regulator */
adc->vref = devm_regulator_get(dev, "xoadc-ref"); adc->vref = devm_regulator_get(dev, "xoadc-ref");
if (IS_ERR(adc->vref)) { if (IS_ERR(adc->vref))
dev_err(dev, "failed to get XOADC VREF regulator\n"); return dev_err_probe(dev, PTR_ERR(adc->vref),
return PTR_ERR(adc->vref); "failed to get XOADC VREF regulator\n");
}
ret = regulator_enable(adc->vref); ret = regulator_enable(adc->vref);
if (ret) { if (ret) {
dev_err(dev, "failed to enable XOADC VREF regulator\n"); dev_err(dev, "failed to enable XOADC VREF regulator\n");