Blaster4385/linux-IllusionX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nfsd: don't leak dentry count on mnt_want_write failure

Browse source 
The exit cleanup isn't quite right here.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
J. Bruce Fields 2011-01-14 20:00:02 -05:00
parent 1bae4ce27c
commit 541ce98c10
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
fs/nfsd/vfs.c
View file

@ -1812,22 +1812,22 @@ nfsd_unlink(struct svc_rqst *rqstp, struct svc_fh *fhp, int type,
host_err = mnt_want_write(fhp->fh_export->ex_path.mnt);
if (host_err)
goto out_nfserr;
goto out_put;
host_err = nfsd_break_lease(rdentry->d_inode);
if (host_err)
goto out_put;
goto out_drop_write;
if (type != S_IFDIR)
host_err = vfs_unlink(dirp, rdentry);
else
host_err = vfs_rmdir(dirp, rdentry);
if (!host_err)
host_err = commit_metadata(fhp);
out_drop_write:
mnt_drop_write(fhp->fh_export->ex_path.mnt);
out_put:
dput(rdentry);
if (!host_err)
host_err = commit_metadata(fhp);
mnt_drop_write(fhp->fh_export->ex_path.mnt);
out_nfserr:
err = nfserrno(host_err);
out: