smb: client: fix double put of @cfile in smb2_rename_path()
If smb2_set_path_attr() is called with a valid @cfile and returned
-EINVAL, we need to call cifs_get_writable_path() again as the
reference of @cfile was already dropped by previous smb2_compound_op()
call.
Fixes: 71f15c90e7
("smb: client: retry compound request without reusing lease")
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
parent
7ccc146546
commit
3523a3df03
1 changed files with 2 additions and 0 deletions
|
@ -1106,6 +1106,8 @@ int smb2_rename_path(const unsigned int xid,
|
|||
co, DELETE, SMB2_OP_RENAME, cfile, source_dentry);
|
||||
if (rc == -EINVAL) {
|
||||
cifs_dbg(FYI, "invalid lease key, resending request without lease");
|
||||
cifs_get_writable_path(tcon, from_name,
|
||||
FIND_WR_WITH_DELETE, &cfile);
|
||||
rc = smb2_set_path_attr(xid, tcon, from_name, to_name, cifs_sb,
|
||||
co, DELETE, SMB2_OP_RENAME, cfile, NULL);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue