Blaster4385/linux-IllusionX
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

rtc: m41t80: use rtc_lock/rtc_unlock

Browse source 
Avoid accessing directly rtc->ops_lock and use the RTC core helpers.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210119220653.677750-8-alexandre.belloni@bootlin.com
This commit is contained in:
Alexandre Belloni 2021-01-19 23:06:46 +01:00
parent 92e2c3e61d
commit 06c6e32167
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/rtc/rtc-m41t80.c
View file

@ -158,21 +158,20 @@ static irqreturn_t m41t80_handle_irq(int irq, void *dev_id)
{ {
struct i2c_client *client = dev_id; struct i2c_client *client = dev_id;
struct m41t80_data *m41t80 = i2c_get_clientdata(client); struct m41t80_data *m41t80 = i2c_get_clientdata(client);
struct mutex *lock = &m41t80->rtc->ops_lock;
unsigned long events = 0; unsigned long events = 0;
int flags, flags_afe; int flags, flags_afe;
mutex_lock(lock); rtc_lock(m41t80->rtc);
flags_afe = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON); flags_afe = i2c_smbus_read_byte_data(client, M41T80_REG_ALARM_MON);
if (flags_afe < 0) { if (flags_afe < 0) {
mutex_unlock(lock); rtc_unlock(m41t80->rtc);
return IRQ_NONE; return IRQ_NONE;
} }
flags = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS); flags = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS);
if (flags <= 0) { if (flags <= 0) {
mutex_unlock(lock); rtc_unlock(m41t80->rtc);
return IRQ_NONE; return IRQ_NONE;
} }
@ -189,7 +188,7 @@ static irqreturn_t m41t80_handle_irq(int irq, void *dev_id)
flags_afe); flags_afe);
} }
mutex_unlock(lock); rtc_unlock(m41t80->rtc);
return IRQ_HANDLED; return IRQ_HANDLED;
} }